ADHOC/replicant-packages_apps_Email
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix uncommanded exit from MessageList with 2+ accounts

Browse Source 
* When you have 2 or more accounts configured, MessageList gets confused.
* If you are viewing a mailbox from account A, and account B does a
  background sync, MessageList gets confused by the reports coming back
  from the Controller.  It gives up and returns to the Accounts list.
* This change adds a check for the current account and ignores the
  MessageList updates if we weren't actually waiting for them.
* To test the positive case for this code (make sure we didn't break it),
  verify that the inbox on an IMAP account is displayed properly
  immediately after you add it.

Bug: 2619513
Change-Id: Ib31254b4099ba6b7922b06d42e2b7928551e4fb2
This commit is contained in:
Andrew Stadler 2010-04-23 12:17:43 -07:00
parent 6cfa8001a8
commit 88fb7f7cd0
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/com/android/email/activity/MessageList.java
View File

@ -1102,7 +1102,7 @@ public class MessageList extends ListActivity implements OnItemClickListener, On
final boolean accountExists = Account.isValidId(MessageList.this, mAccountId);
if (accountExists && mOkToRecurse) {
// launch network lookup
mControllerCallback.mWaitForMailboxType = mMailboxType;
mControllerCallback.presetMailboxListCallback(mMailboxType, mAccountId);
mController.updateMailboxList(mAccountId, mControllerCallback);
} else {
// We don't want to do the network lookup, or the account doesn't exist in the
@ -1436,19 +1436,26 @@ public class MessageList extends ListActivity implements OnItemClickListener, On
// This is used to alter the connection banner operation for sending messages
MessagingException mSendMessageException;
// This is preset for use by updateMailboxListCallback
int mWaitForMailboxType = -1;
// These values are set by FindMailboxTask, and used by updateMailboxListCallback
// Access to these must be synchronized because of various threads dealing with them
private int mWaitForMailboxType = -1;
private long mWaitForMailboxAccount = -1;
// TODO check accountKey and only react to relevant notifications
public void updateMailboxListCallback(MessagingException result, long accountKey,
int progress) {
public synchronized void presetMailboxListCallback(int mailboxType, long accountId) {
mWaitForMailboxType = mailboxType;
mWaitForMailboxAccount = accountId;
}
public synchronized void updateMailboxListCallback(MessagingException result,
long accountKey, int progress) {
// updateMailboxList is never the end goal in MessageList, so we don't show
// these errors. There are a couple of corner cases that we miss reporting, but
// this is better than reporting a number of non-problem intermediate states.
// updateBanner(result, progress, mMailboxId);
updateProgress(result, progress);
if (progress == 100) {
if (progress == 100 && accountKey == mWaitForMailboxAccount) {
mWaitForMailboxAccount = -1;
mHandler.lookupMailboxType(accountKey, mWaitForMailboxType);
}
}