Temporarily disabling crashing test.
The problem is that this test creates a partial account which will be used by the activity, but the account is picked up by MailService too (which is probably not intentional), which crashes because the account is not properly constructed. (empty address) Bug 2938323 Change-Id: Ie9ba19ebf72431d086014c1dc191a0c71769dea4
This commit is contained in:
Makoto Onuki
parent
a14a24a5bc
commit
8852708238
@ -14,120 +14,130 @@
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package com.android.email.activity.setup;
|
||||
// TODO Test crashes. Fix it.
|
||||
|
||||
import com.android.email.R;
|
||||
import com.android.email.provider.EmailContent;
|
||||
import com.android.email.provider.EmailContent.HostAuth;
|
||||
|
||||
import android.content.ContentUris;
|
||||
import android.content.Context;
|
||||
import android.content.Intent;
|
||||
import android.net.Uri;
|
||||
import android.test.ActivityInstrumentationTestCase2;
|
||||
import android.test.suitebuilder.annotation.MediumTest;
|
||||
import android.widget.Button;
|
||||
|
||||
/**
|
||||
* Tests of basic UI logic in the AccountSetupNamesTest screen.
|
||||
* You can run this entire test case with:
|
||||
* runtest -c com.android.email.activity.setup.AccountSetupNamesTests email
|
||||
/*
|
||||
The problem is that this test creates a partial account which will be
|
||||
used by the activity, but the account is picked up by MailService too
|
||||
(which is probably not intentional), which crashes because the account
|
||||
is not properly constructed. (empty address)
|
||||
*/
|
||||
@MediumTest
|
||||
public class AccountSetupNamesTests extends ActivityInstrumentationTestCase2<AccountSetupNames> {
|
||||
private long mAccountId;
|
||||
private EmailContent.Account mAccount;
|
||||
|
||||
private Context mContext;
|
||||
private AccountSetupNames mActivity;
|
||||
private Button mDoneButton;
|
||||
|
||||
public AccountSetupNamesTests() {
|
||||
super(AccountSetupNames.class);
|
||||
}
|
||||
|
||||
/**
|
||||
* Common setup code for all tests.
|
||||
*/
|
||||
@Override
|
||||
protected void setUp() throws Exception {
|
||||
super.setUp();
|
||||
|
||||
mContext = this.getInstrumentation().getTargetContext();
|
||||
}
|
||||
|
||||
/**
|
||||
* Delete any dummy accounts we set up for this test
|
||||
*/
|
||||
@Override
|
||||
protected void tearDown() throws Exception {
|
||||
if (mAccount != null) {
|
||||
Uri uri = ContentUris.withAppendedId(
|
||||
EmailContent.Account.CONTENT_URI, mAccountId);
|
||||
mContext.getContentResolver().delete(uri, null, null);
|
||||
}
|
||||
|
||||
// must call last because it scrubs member variables
|
||||
super.tearDown();
|
||||
}
|
||||
|
||||
/**
|
||||
* Test a "good" account name (enables the button)
|
||||
*/
|
||||
public void testGoodAccountName() {
|
||||
Intent i = getTestIntent("imap", "GoodName");
|
||||
this.setActivityIntent(i);
|
||||
|
||||
getActivityAndFields();
|
||||
|
||||
assertTrue(mDoneButton.isEnabled());
|
||||
}
|
||||
|
||||
/**
|
||||
* Test a "bad" account name (disables the button)
|
||||
*/
|
||||
public void testBadAccountName() {
|
||||
Intent i = getTestIntent("imap", "");
|
||||
this.setActivityIntent(i);
|
||||
|
||||
getActivityAndFields();
|
||||
|
||||
assertFalse(mDoneButton.isEnabled());
|
||||
}
|
||||
|
||||
/**
|
||||
* Test a "bad" account name (disables the button)
|
||||
*/
|
||||
public void testEasAccountName() {
|
||||
Intent i = getTestIntent("eas", "");
|
||||
this.setActivityIntent(i);
|
||||
|
||||
getActivityAndFields();
|
||||
|
||||
assertTrue(mDoneButton.isEnabled());
|
||||
}
|
||||
|
||||
/**
|
||||
* Get the activity (which causes it to be started, using our intent) and get the UI fields
|
||||
*/
|
||||
private void getActivityAndFields() {
|
||||
mActivity = getActivity();
|
||||
mDoneButton = (Button) mActivity.findViewById(R.id.done);
|
||||
}
|
||||
|
||||
/**
|
||||
* Create an intent with the Account in it, using protocol as the protocol and name as the
|
||||
* user's sender name
|
||||
*/
|
||||
private Intent getTestIntent(String protocol, String name) {
|
||||
mAccount = new EmailContent.Account();
|
||||
mAccount.setSenderName(name);
|
||||
HostAuth hostAuth = new HostAuth();
|
||||
hostAuth.mProtocol = protocol;
|
||||
mAccount.mHostAuthRecv = hostAuth;
|
||||
mAccount.save(mContext);
|
||||
mAccountId = mAccount.mId;
|
||||
SetupData.init(SetupData.FLOW_MODE_NORMAL, mAccount);
|
||||
return new Intent(Intent.ACTION_MAIN);
|
||||
}
|
||||
}
|
||||
//
|
||||
//package com.android.email.activity.setup;
|
||||
//
|
||||
//import com.android.email.R;
|
||||
//import com.android.email.provider.EmailContent;
|
||||
//import com.android.email.provider.EmailContent.HostAuth;
|
||||
//
|
||||
//import android.content.ContentUris;
|
||||
//import android.content.Context;
|
||||
//import android.content.Intent;
|
||||
//import android.net.Uri;
|
||||
//import android.test.ActivityInstrumentationTestCase2;
|
||||
//import android.test.suitebuilder.annotation.MediumTest;
|
||||
//import android.widget.Button;
|
||||
//
|
||||
///**
|
||||
// * Tests of basic UI logic in the AccountSetupNamesTest screen.
|
||||
// * You can run this entire test case with:
|
||||
// * runtest -c com.android.email.activity.setup.AccountSetupNamesTests email
|
||||
// */
|
||||
//@MediumTest
|
||||
//public class AccountSetupNamesTests extends ActivityInstrumentationTestCase2<AccountSetupNames> {
|
||||
// private long mAccountId;
|
||||
// private EmailContent.Account mAccount;
|
||||
//
|
||||
// private Context mContext;
|
||||
// private AccountSetupNames mActivity;
|
||||
// private Button mDoneButton;
|
||||
//
|
||||
// public AccountSetupNamesTests() {
|
||||
// super(AccountSetupNames.class);
|
||||
// }
|
||||
//
|
||||
// /**
|
||||
// * Common setup code for all tests.
|
||||
// */
|
||||
// @Override
|
||||
// protected void setUp() throws Exception {
|
||||
// super.setUp();
|
||||
//
|
||||
// mContext = this.getInstrumentation().getTargetContext();
|
||||
// }
|
||||
//
|
||||
// /**
|
||||
// * Delete any dummy accounts we set up for this test
|
||||
// */
|
||||
// @Override
|
||||
// protected void tearDown() throws Exception {
|
||||
// if (mAccount != null) {
|
||||
// Uri uri = ContentUris.withAppendedId(
|
||||
// EmailContent.Account.CONTENT_URI, mAccountId);
|
||||
// mContext.getContentResolver().delete(uri, null, null);
|
||||
// }
|
||||
//
|
||||
// // must call last because it scrubs member variables
|
||||
// super.tearDown();
|
||||
// }
|
||||
//
|
||||
// /**
|
||||
// * Test a "good" account name (enables the button)
|
||||
// */
|
||||
// public void testGoodAccountName() {
|
||||
// Intent i = getTestIntent("imap", "GoodName");
|
||||
// this.setActivityIntent(i);
|
||||
//
|
||||
// getActivityAndFields();
|
||||
//
|
||||
// assertTrue(mDoneButton.isEnabled());
|
||||
// }
|
||||
//
|
||||
// /**
|
||||
// * Test a "bad" account name (disables the button)
|
||||
// */
|
||||
// public void testBadAccountName() {
|
||||
// Intent i = getTestIntent("imap", "");
|
||||
// this.setActivityIntent(i);
|
||||
//
|
||||
// getActivityAndFields();
|
||||
//
|
||||
// assertFalse(mDoneButton.isEnabled());
|
||||
// }
|
||||
//
|
||||
// /**
|
||||
// * Test a "bad" account name (disables the button)
|
||||
// */
|
||||
// public void testEasAccountName() {
|
||||
// Intent i = getTestIntent("eas", "");
|
||||
// this.setActivityIntent(i);
|
||||
//
|
||||
// getActivityAndFields();
|
||||
//
|
||||
// assertTrue(mDoneButton.isEnabled());
|
||||
// }
|
||||
//
|
||||
// /**
|
||||
// * Get the activity (which causes it to be started, using our intent) and get the UI fields
|
||||
// */
|
||||
// private void getActivityAndFields() {
|
||||
// mActivity = getActivity();
|
||||
// mDoneButton = (Button) mActivity.findViewById(R.id.done);
|
||||
// }
|
||||
//
|
||||
// /**
|
||||
// * Create an intent with the Account in it, using protocol as the protocol and name as the
|
||||
// * user's sender name
|
||||
// */
|
||||
// private Intent getTestIntent(String protocol, String name) {
|
||||
// mAccount = new EmailContent.Account();
|
||||
// mAccount.setSenderName(name);
|
||||
// HostAuth hostAuth = new HostAuth();
|
||||
// hostAuth.mProtocol = protocol;
|
||||
// mAccount.mHostAuthRecv = hostAuth;
|
||||
// mAccount.save(mContext);
|
||||
// mAccountId = mAccount.mId;
|
||||
// SetupData.init(SetupData.FLOW_MODE_NORMAL, mAccount);
|
||||
// return new Intent(Intent.ACTION_MAIN);
|
||||
// }
|
||||
//}
|
||||
|
||||
Loading…
Reference in New Issue
Block a user