ADHOC
/
replicant-packages_apps_Email
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix bug in GroupMessagingListener and add unit tests

This commit is contained in:
Andrew Stadler 2009-07-02 14:29:02 -07:00
parent 54693e8446
commit 45f9dd22e1
2 changed files with 78 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/com/android/email/GroupMessagingListener.java
View File

@ -48,7 +48,7 @@ public class GroupMessagingListener extends MessagingListener {
}
synchronized public boolean isActiveListener(MessagingListener listener) {
return mListenersMap.contains(listener);
return mListenersMap.containsKey(listener);
}
@Override

77
tests/src/com/android/email/GroupMessagingListenerUnitTests.java Normal file
View File

@ -0,0 +1,77 @@
/*
* Copyright (C) 2009 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.email;
import android.test.suitebuilder.annotation.SmallTest;
import junit.framework.TestCase;
/**
* This is a series of unit tests for the GroupMessagingListener class.
*/
@SmallTest
public class GroupMessagingListenerUnitTests extends TestCase {
/**
* Tests adding and removing elements from the listener
*/
public void testAddRemove() {
GroupMessagingListener groupListener = new GroupMessagingListener();
MessagingListener listener1 = new MessagingListener();
MessagingListener listener2 = new MessagingListener();
groupListener.addListener(listener1);
groupListener.addListener(listener2);
groupListener.removeListener(listener1);
groupListener.removeListener(listener2);
}
/**
* Tests isActiveListener()
*/
public void testIsActiveListener() {
GroupMessagingListener groupListener = new GroupMessagingListener();
MessagingListener listener1 = new MessagingListener();
MessagingListener listener2 = new MessagingListener();
assertFalse(groupListener.isActiveListener(listener1));
assertFalse(groupListener.isActiveListener(listener2));
groupListener.addListener(listener1);
assertTrue(groupListener.isActiveListener(listener1));
assertFalse(groupListener.isActiveListener(listener2));
groupListener.addListener(listener2);
assertTrue(groupListener.isActiveListener(listener1));
assertTrue(groupListener.isActiveListener(listener2));
groupListener.removeListener(listener1);
assertFalse(groupListener.isActiveListener(listener1));
assertTrue(groupListener.isActiveListener(listener2));
groupListener.removeListener(listener2);
assertFalse(groupListener.isActiveListener(listener1));
assertFalse(groupListener.isActiveListener(listener2));
}
/**
* TODO: Test that if you add a set of listeners, they will be called
*/
}