ADHOC/replicant-packages_apps_Email
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix NPE in AttachmentDownloadServiceTests.testDownloadSet

Browse Source 
Bug 3353834

Change-Id: I5cf475ff174bffce80a435c80b1fd85c0be146e9
This commit is contained in:
Makoto Onuki 2011-01-14 11:47:26 -08:00
parent 96497dc60e
commit 36cc9c18ed
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/com/android/email/service/AttachmentDownloadService.java
View File

@ -90,7 +90,7 @@ public class AttachmentDownloadService extends Service implements Runnable {
/*package*/ static AttachmentDownloadService sRunningService = null;
/*package*/ Context mContext;
Preferences mPreferences;
private final Preferences mPreferences;
/*package*/ final DownloadSet mDownloadSet = new DownloadSet(new DownloadComparator());
private final HashMap<Long, Class<? extends Service>> mAccountServiceMap =
@ -521,7 +521,7 @@ public class AttachmentDownloadService extends Service implements Runnable {
}
// If we're an attachment on forwarded mail, and if we're not still blocked,
// try to send pending mail now (as mediated by MailService)
if ((req != null) &&
if ((req != null) &&
!Utility.hasUnloadedAttachments(mContext, attachment.mMessageKey)) {
if (Email.DEBUG) {
Log.d(TAG, "== Downloads finished for outgoing msg #" + req.messageId);
@ -547,6 +547,10 @@ public class AttachmentDownloadService extends Service implements Runnable {
}
}
public AttachmentDownloadService() {
mPreferences = Preferences.getPreferences(this);
}
/**
* Calculate the download priority of an Attachment. A priority of zero means that the
* attachment is not marked for download.
@ -786,7 +790,6 @@ public class AttachmentDownloadService extends Service implements Runnable {
public void run() {
mContext = this;
mAccountManagerStub = new AccountManagerStub(this);
mPreferences = Preferences.getPreferences(this);
// Run through all attachments in the database that require download and add them to
// the queue