ADHOC/replicant-packages_apps_Email
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge "Try to avoid cases when we flicker "No messages""

Browse Source
This commit is contained in:
Ben Komalo 2011-09-21 17:19:16 -07:00 committed by Android (Google) Code Review
commit 0c56eedae5
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/com/android/email/activity/MessageListFragment.java
View File

@ -1231,7 +1231,6 @@ public class MessageListFragment extends ListFragment
message.setText(R.string.search_slow_warning_message); message.setText(R.string.search_slow_warning_message);
root.addView(mWarningContainer); root.addView(mWarningContainer);
} }
} }
/** /**
@ -1326,6 +1325,14 @@ public class MessageListFragment extends ListFragment
if (mIsFirstLoad) { if (mIsFirstLoad) {
UiUtilities.setVisibilitySafe(mWarningContainer, View.GONE); UiUtilities.setVisibilitySafe(mWarningContainer, View.GONE);
mListPanel.setVisibility(View.VISIBLE); mListPanel.setVisibility(View.VISIBLE);
// Setting the adapter will automatically transition from "Loading" to showing
// the list, which could show "No messages". Avoid showing that on the first sync,
// if we know we're still potentially loading more.
if (!isEmptyAndLoading(cursor)) {
setListAdapter(mListAdapter);
}
} else if ((getListAdapter() == null) && !isEmptyAndLoading(cursor)) {
setListAdapter(mListAdapter); setListAdapter(mListAdapter);
} }
@ -1339,6 +1346,16 @@ public class MessageListFragment extends ListFragment
mIsFirstLoad = false; mIsFirstLoad = false;
} }
/**
* Determines whether or not the list is empty, but we're still potentially loading data.
* This represents an ambiguous state where we may not want to show "No messages", since
* it may still just be loading.
*/
private boolean isEmptyAndLoading(Cursor cursor) {
return (cursor.getCount() == 0)
&& mRefreshManager.isMessageListRefreshing(mMailbox.mId);
}
@Override @Override
public void onLoaderReset(Loader<Cursor> loader) { public void onLoaderReset(Loader<Cursor> loader) {
if (Logging.DEBUG_LIFECYCLE && Email.DEBUG) { if (Logging.DEBUG_LIFECYCLE && Email.DEBUG) {