ADHOC/replicant-packages_apps_Email
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge "Prevent duplicate mailbox creation"

Browse Source
This commit is contained in:
Andy Stadler 2011-01-05 14:28:12 -08:00 committed by Android (Google) Code Review
commit 0bd7ab96aa
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/com/android/email/Controller.java
View File

@ -427,13 +427,18 @@ public class Controller {
} }
/** /**
* Look for a specific mailbox, creating it if necessary, and return the mailbox id.
* This is a blocking operation and should not be called from the UI thread.
*
* Synchronized so multiple threads can call it (and not risk creating duplicate boxes).
*
* @param accountId the account id * @param accountId the account id
* @param mailboxType the mailbox type (e.g. EmailContent.Mailbox.TYPE_TRASH) * @param mailboxType the mailbox type (e.g. EmailContent.Mailbox.TYPE_TRASH)
* @return the id of the mailbox. The mailbox is created if not existing. * @return the id of the mailbox. The mailbox is created if not existing.
* Returns Mailbox.NO_MAILBOX if the accountId or mailboxType are negative. * Returns Mailbox.NO_MAILBOX if the accountId or mailboxType are negative.
* Does not validate the input in other ways (e.g. does not verify the existence of account). * Does not validate the input in other ways (e.g. does not verify the existence of account).
*/ */
public long findOrCreateMailboxOfType(long accountId, int mailboxType) { public synchronized long findOrCreateMailboxOfType(long accountId, int mailboxType) {
if (accountId < 0 || mailboxType < 0) { if (accountId < 0 || mailboxType < 0) {
return Mailbox.NO_MAILBOX; return Mailbox.NO_MAILBOX;
} }