From 2aff7025482cc40d2ebd45f81cdb318ac1c6f868 Mon Sep 17 00:00:00 2001 From: Lingyun Zhu Date: Tue, 20 Nov 2012 19:24:35 +0800 Subject: [PATCH] Graphics:Add error check when create GraphicBuffer Change-Id: Ib0ca59bf1dfe4ae0266c29c91c1dbe3d02c0904e Author: Lingyun Zhu Signed-off-by: Lingyun Zhu Signed-off-by: Shuo Gao Signed-off-by: Bruce Beare Signed-off-by: Jack Ren Author-tracking-BZ: 50141 --- libs/gui/IGraphicBufferProducer.cpp | 6 +++++- libs/ui/GraphicBuffer.cpp | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/libs/gui/IGraphicBufferProducer.cpp b/libs/gui/IGraphicBufferProducer.cpp index 63d7628a5..c33543958 100644 --- a/libs/gui/IGraphicBufferProducer.cpp +++ b/libs/gui/IGraphicBufferProducer.cpp @@ -62,7 +62,11 @@ public: bool nonNull = reply.readInt32(); if (nonNull) { *buf = new GraphicBuffer(); - reply.read(**buf); + result = reply.read(**buf); + if(result != NO_ERROR) { + (*buf).clear(); + return result; + } } result = reply.readInt32(); return result; diff --git a/libs/ui/GraphicBuffer.cpp b/libs/ui/GraphicBuffer.cpp index 580788d0e..83ae46983 100644 --- a/libs/ui/GraphicBuffer.cpp +++ b/libs/ui/GraphicBuffer.cpp @@ -281,6 +281,8 @@ status_t GraphicBuffer::unflatten(void const* buffer, size_t size, if (handle != 0) { status_t err = mBufferMapper.registerBuffer(handle); if (err != NO_ERROR) { + width = height = stride = format = usage = 0; + handle = NULL; ALOGE("unflatten: registerBuffer failed: %s (%d)", strerror(-err), err); return err;