From ea4fdd4beb83ab7019753a144d9afac6728dd3ee Mon Sep 17 00:00:00 2001 From: Jesse Hall Date: Mon, 12 Aug 2013 16:43:34 -0700 Subject: [PATCH] Don't swallow eglCreateContext errors If the implementation eglCreateContext failed, we called eglGetError(), so we could check that it set the EGL error properly. But since we'd already called this, when the app called eglGetError() it would get EGL_SUCCESS! Bug: 10181333 Change-Id: Ic45d3a8fcb8c4421e04844c6d2f52761790b5948 --- opengl/libs/EGL/eglApi.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/opengl/libs/EGL/eglApi.cpp b/opengl/libs/EGL/eglApi.cpp index 8a0522ef6..e5e2dc05d 100644 --- a/opengl/libs/EGL/eglApi.cpp +++ b/opengl/libs/EGL/eglApi.cpp @@ -552,12 +552,6 @@ EGLContext eglCreateContext(EGLDisplay dpy, EGLConfig config, GLTrace_eglCreateContext(version, c); #endif return c; - } else { - EGLint error = eglGetError(); - ALOGE_IF(error == EGL_SUCCESS, - "eglCreateContext(%p, %p, %p, %p) returned EGL_NO_CONTEXT " - "but no EGL error!", - dpy, config, share_list, attrib_list); } } return EGL_NO_CONTEXT;