diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp index e76f1fb18..561ecabeb 100644 --- a/services/surfaceflinger/SurfaceFlinger.cpp +++ b/services/surfaceflinger/SurfaceFlinger.cpp @@ -1743,7 +1743,7 @@ void SurfaceFlinger::doDisplayComposition(const sp& hw, } if (CC_LIKELY(!mDaltonize && !mHasColorMatrix)) { - doComposeSurfaces(hw, dirtyRegion); + if (!doComposeSurfaces(hw, dirtyRegion)) return; } else { RenderEngine& engine(getRenderEngine()); mat4 colorMatrix = mColorMatrix; @@ -1762,7 +1762,7 @@ void SurfaceFlinger::doDisplayComposition(const sp& hw, hw->swapBuffers(getHwComposer()); } -void SurfaceFlinger::doComposeSurfaces(const sp& hw, const Region& dirty) +bool SurfaceFlinger::doComposeSurfaces(const sp& hw, const Region& dirty) { RenderEngine& engine(getRenderEngine()); const int32_t id = hw->getHwcDisplayId(); @@ -1775,7 +1775,11 @@ void SurfaceFlinger::doComposeSurfaces(const sp& hw, const if (!hw->makeCurrent(mEGLDisplay, mEGLContext)) { ALOGW("DisplayDevice::makeCurrent failed. Aborting surface composition for display %s", hw->getDisplayName().string()); - return; + eglMakeCurrent(mEGLDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT); + if(!getDefaultDisplayDevice()->makeCurrent(mEGLDisplay, mEGLContext)) { + ALOGE("DisplayDevice::makeCurrent on default display failed. Aborting."); + } + return false; } // Never touch the framebuffer if we don't have any framebuffer layers @@ -1883,6 +1887,7 @@ void SurfaceFlinger::doComposeSurfaces(const sp& hw, const // disable scissor at the end of the frame engine.disableScissor(); + return true; } void SurfaceFlinger::drawWormhole(const sp& hw, const Region& region) const { diff --git a/services/surfaceflinger/SurfaceFlinger.h b/services/surfaceflinger/SurfaceFlinger.h index 2cc522b1a..710dac712 100644 --- a/services/surfaceflinger/SurfaceFlinger.h +++ b/services/surfaceflinger/SurfaceFlinger.h @@ -377,7 +377,10 @@ private: void doComposition(); void doDebugFlashRegions(); void doDisplayComposition(const sp& hw, const Region& dirtyRegion); - void doComposeSurfaces(const sp& hw, const Region& dirty); + + // compose surfaces for display hw. this fails if using GL and the surface + // has been destroyed and is no longer valid. + bool doComposeSurfaces(const sp& hw, const Region& dirty); void postFramebuffer(); void drawWormhole(const sp& hw, const Region& region) const;