From de288fe2d43adfa1b2243ae534faaf832bf50491 Mon Sep 17 00:00:00 2001 From: Jesse Hall Date: Tue, 4 Nov 2014 08:30:48 -0800 Subject: [PATCH] Revert "bufferqueue: workaround: allow NULL fence with queueBuffer" Underlying bug has been fixed, workaround no longer needed This reverts commit 5b0cbcf9464dbcda9d19ae978911222806ec8bdc. Change-Id: Ic9532b407d1291a7780a12a75aaa117ae4aa9fcb --- libs/gui/BufferQueueProducer.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libs/gui/BufferQueueProducer.cpp b/libs/gui/BufferQueueProducer.cpp index 284ddb2bf..03bd4fd5b 100644 --- a/libs/gui/BufferQueueProducer.cpp +++ b/libs/gui/BufferQueueProducer.cpp @@ -523,12 +523,7 @@ status_t BufferQueueProducer::queueBuffer(int slot, if (fence == NULL) { BQ_LOGE("queueBuffer: fence is NULL"); - // Temporary workaround for b/17946343: soldier-on instead of returning an error. This - // prevents the client from dying, at the risk of visible corruption due to hwcomposer - // reading the buffer before the producer is done rendering it. Unless the buffer is the - // last frame of an animation, the corruption will be transient. - fence = Fence::NO_FENCE; - // return BAD_VALUE; + return BAD_VALUE; } switch (scalingMode) {