From b4ba50dd833d8b94043635663f2ee1ad0cb54b35 Mon Sep 17 00:00:00 2001 From: Mathias Agopian Date: Tue, 23 Apr 2013 14:14:06 +0200 Subject: [PATCH] fix a typo in EGL loader the code intended to filter out the software-renderer, but the test as written was essentially a no-op. the problem didn't happen most of the time because we had updated egl.cfg to not even list the software renderer. the test as written didn't generate a compile-time error because String8 has a const char* cast operator; but the end result was to compare pointers instead of the string itself. http://code.google.com/p/android/issues/detail?id=54606 Change-Id: I739dd1c838fbc24c5643a631fae19713a8ef1717 --- opengl/libs/EGL/Loader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opengl/libs/EGL/Loader.cpp b/opengl/libs/EGL/Loader.cpp index 00bfa5a3b..73fea3437 100644 --- a/opengl/libs/EGL/Loader.cpp +++ b/opengl/libs/EGL/Loader.cpp @@ -161,7 +161,7 @@ Loader::Loader() if (sscanf(line, "%u %u %s", &dpy, &impl, tag) == 3) { //ALOGD(">>> %u %u %s", dpy, impl, tag); // We only load the h/w accelerated implementation - if (tag != String8("android")) { + if (String8("android") != tag) { mDriverTag = tag; } }