ADHOC/replicant-frameworks_native
3
0
Fork 0
Code Issues 7 Pull Requests Releases Wiki Activity

crash if getNativeBuffer() called on NULL GraphicBuffer

Browse Source 
If getNativeBuffer() is called on a NULL GraphicBuffer the
static_cast of this from GraphicBuffer* to ANativeWindowBuffer*
will return a small pointer like (ANativeWindowBuffer*)0x10.
This value can propagate past NULL checks until it causes a crash
far away from the original NULL pointer.  Crash immediately
instead.

Change-Id: Id614b9eb1484108b3c3c733545309844c4b87532
This commit is contained in:
Colin Cross 2014-07-22 15:55:08 -07:00 committed by The Android Automerger
parent 9b365296a7
commit b2aada6e84
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libs/ui/GraphicBuffer.cpp
View File

@ -126,6 +126,7 @@ void GraphicBuffer::dumpAllocationsToSystemLog()
ANativeWindowBuffer* GraphicBuffer::getNativeBuffer() const ANativeWindowBuffer* GraphicBuffer::getNativeBuffer() const
{ {
LOG_ALWAYS_FATAL_IF(this == NULL, "getNativeBuffer() called on NULL GraphicBuffer");
return static_cast<ANativeWindowBuffer*>( return static_cast<ANativeWindowBuffer*>(
const_cast<GraphicBuffer*>(this)); const_cast<GraphicBuffer*>(this));
} }