ADHOC/replicant-frameworks_native
3
0
Fork 0
Code Issues 7 Pull Requests Releases Wiki Activity

we need to guarantee that h/w comp set() is called when a buffer has been retired

Browse Source 
removed a test that could violate this guarantee. note that we
have no proof tha this ever happened, but consequences could be
hard lock-ups.

the code here was intended to track the region to update for displays
that can do partial update. the logic discarded the update entirely
if that region was empty. instead we just redraw the whole thing
(note that we should never be there with an empty region and retired
buffers though).

Bug: 5466259

Change-Id: I91ccab3b1a599e729e438eb833939e2236da6854
This commit is contained in:
Mathias Agopian 2011-10-16 18:46:35 -07:00
parent 1c00a8bdf1
commit a44b041639
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
services/surfaceflinger/SurfaceFlinger.cpp
View File

@ -452,7 +452,7 @@ bool SurfaceFlinger::threadLoop()
} }
const DisplayHardware& hw(graphicPlane(0).displayHardware()); const DisplayHardware& hw(graphicPlane(0).displayHardware());
if (LIKELY(hw.canDraw() && !isFrozen())) { if (LIKELY(hw.canDraw())) {
// repaint the framebuffer (if needed) // repaint the framebuffer (if needed)
const int index = hw.getCurrentBufferIndex(); const int index = hw.getCurrentBufferIndex();
@ -479,15 +479,13 @@ bool SurfaceFlinger::threadLoop()
void SurfaceFlinger::postFramebuffer() void SurfaceFlinger::postFramebuffer()
{ {
if (!mSwapRegion.isEmpty()) { const DisplayHardware& hw(graphicPlane(0).displayHardware());
const DisplayHardware& hw(graphicPlane(0).displayHardware()); const nsecs_t now = systemTime();
const nsecs_t now = systemTime(); mDebugInSwapBuffers = now;
mDebugInSwapBuffers = now; hw.flip(mSwapRegion);
hw.flip(mSwapRegion); mLastSwapBufferTime = systemTime() - now;
mLastSwapBufferTime = systemTime() - now; mDebugInSwapBuffers = 0;
mDebugInSwapBuffers = 0; mSwapRegion.clear();
mSwapRegion.clear();
}
} }
void SurfaceFlinger::handleConsoleEvents() void SurfaceFlinger::handleConsoleEvents()