From 91b2ca8562763c981c4ce93148db80adb51d0cb6 Mon Sep 17 00:00:00 2001 From: Andy McFadden Date: Fri, 13 Jun 2014 14:04:23 -0700 Subject: [PATCH] Add two new display info fields This adds SurfaceFlinger's app VSYNC offset and buffer deadline values to DisplayInfo. Bug 14612039 Change-Id: Ie0ab21d388fe2764f2b6f71bd1cefa33dc861a73 --- include/ui/DisplayInfo.h | 3 +++ services/surfaceflinger/SurfaceFlinger.cpp | 20 ++++++++++++++++++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/include/ui/DisplayInfo.h b/include/ui/DisplayInfo.h index 3b5cd6d83..799944f3e 100644 --- a/include/ui/DisplayInfo.h +++ b/include/ui/DisplayInfo.h @@ -19,6 +19,7 @@ #include #include +#include #include @@ -33,6 +34,8 @@ struct DisplayInfo { float density; uint8_t orientation; bool secure; + nsecs_t appVsyncOffset; + nsecs_t presentationDeadline; }; /* Display orientations as defined in Surface.java and ISurfaceComposer.h. */ diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp index edf867a96..4ecdc8b6a 100644 --- a/services/surfaceflinger/SurfaceFlinger.cpp +++ b/services/surfaceflinger/SurfaceFlinger.cpp @@ -576,6 +576,22 @@ status_t SurfaceFlinger::getDisplayConfigs(const sp& display, info.xdpi = xdpi; info.ydpi = ydpi; info.fps = float(1e9 / hwConfig.refresh); + info.appVsyncOffset = VSYNC_EVENT_PHASE_OFFSET_NS; + + // This is how far in advance a buffer must be queued for + // presentation at a given time. If you want a buffer to appear + // on the screen at time N, you must submit the buffer before + // (N - presentationDeadline). + // + // Normally it's one full refresh period (to give SF a chance to + // latch the buffer), but this can be reduced by configuring a + // DispSync offset. Any additional delays introduced by the hardware + // composer or panel must be accounted for here. + // + // We add an additional 1ms to allow for processing time and + // differences between the ideal and actual refresh rate. + info.presentationDeadline = + hwConfig.refresh - SF_VSYNC_EVENT_PHASE_OFFSET_NS + 1000000; // All non-virtual displays are currently considered secure. info.secure = true; @@ -586,11 +602,11 @@ status_t SurfaceFlinger::getDisplayConfigs(const sp& display, return NO_ERROR; } -int SurfaceFlinger::getActiveConfig(const sp& display) { +int SurfaceFlinger::getActiveConfig(const sp&) { return 0; } -status_t SurfaceFlinger::setActiveConfig(const sp& display, int id) { +status_t SurfaceFlinger::setActiveConfig(const sp&, int) { return NO_ERROR; }