From 8eb25d552b07ffa799b7b61ad46d0109e7512741 Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Wed, 16 Jul 2014 19:00:46 -0700 Subject: [PATCH] dumpstate: fix dumping traces for vm processes on 64-bit dumpstate was not dumping any stack traces for vm processes because it was failing the string compare for /system/bin/app_process. 64-bit devices use app_process32 and app_process64 instead of app_process, and zygote64 alongside zygote. Change the string matching to be prefix matching. Change-Id: I6970e1b1fedfcd601f8db6af62852422fcb71d59 --- cmds/dumpstate/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmds/dumpstate/utils.c b/cmds/dumpstate/utils.c index 3b19f590d..9451417d4 100644 --- a/cmds/dumpstate/utils.c +++ b/cmds/dumpstate/utils.c @@ -526,7 +526,7 @@ const char *dump_traces() { } data[len] = '\0'; - if (!strcmp(data, "/system/bin/app_process")) { + if (!strncmp(data, "/system/bin/app_process", strlen("/system/bin/app_process"))) { /* skip zygote -- it won't dump its stack anyway */ snprintf(path, sizeof(path), "/proc/%d/cmdline", pid); int fd = open(path, O_RDONLY); @@ -536,7 +536,7 @@ const char *dump_traces() { continue; } data[len] = '\0'; - if (!strcmp(data, "zygote")) { + if (!strncmp(data, "zygote", strlen("zygote"))) { continue; }