From 8c39282e31603b1b594ff1381f2c11e5863c2bbe Mon Sep 17 00:00:00 2001 From: Caio Schnepper Date: Wed, 25 Nov 2015 17:51:30 -0200 Subject: [PATCH] libgui: Don't assign handle to NULL after free is common Reportedly Mali and PowerVR GPUs are crashing when setting handle to NULL So we will set a flag for the devices that might need this aswell Set BOARD_EGL_NEEDS_HANDLE_VALUE=true in BoardConfig.mk to use Change-Id: I6c967f62dc6adced7583d7b2045d11cf5b25fc80 --- libs/ui/Android.mk | 4 ++++ libs/ui/GraphicBuffer.cpp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/libs/ui/Android.mk b/libs/ui/Android.mk index 1ce862652..a8eb67b34 100644 --- a/libs/ui/Android.mk +++ b/libs/ui/Android.mk @@ -56,6 +56,10 @@ ifneq ($(BOARD_FRAMEBUFFER_FORCE_FORMAT),) LOCAL_CFLAGS += -DFRAMEBUFFER_FORCE_FORMAT=$(BOARD_FRAMEBUFFER_FORCE_FORMAT) endif +ifeq ($(BOARD_EGL_NEEDS_HANDLE_VALUE),true) +LOCAL_CFLAGS += -DEGL_NEEDS_HANDLE +endif + LOCAL_MODULE := libui include $(BUILD_SHARED_LIBRARY) diff --git a/libs/ui/GraphicBuffer.cpp b/libs/ui/GraphicBuffer.cpp index d82393855..992c1fe6b 100644 --- a/libs/ui/GraphicBuffer.cpp +++ b/libs/ui/GraphicBuffer.cpp @@ -113,7 +113,7 @@ void GraphicBuffer::free_handle() allocator.free(handle); } -#ifndef EXYNOS4_ENHANCEMENTS +#ifndef EGL_NEEDS_HANDLE handle = NULL; #endif