ADHOC/replicant-frameworks_native
3
0
Fork 0
Code Issues 6 Pull Requests Releases Wiki Activity

utils: clarify scoped tracing functionality

Browse Source 
ScopedTrace objects were being used in place of ATRACE_NAME because of a
misunderstanding of it's function.  Cleared up documentation for usage.

Also explicitly use global namespace for sysprop callback.

Change-Id: I7c248b486b614ccdb841659ca0dcfc644fda670a
This commit is contained in:
Alex Ray 2012-11-30 19:32:12 -08:00
parent c342044368
commit 653078f652
2 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
include/utils/Trace.h
View File

@ -31,15 +31,12 @@
// See <cutils/trace.h> for more ATRACE_* macros.
// ATRACE_CALL traces the beginning and end of the current function. To trace
// the correct start and end times this macro should be the first line of the
// function body.
#define ATRACE_CALL() android::ScopedTrace ___tracer(ATRACE_TAG, __FUNCTION__)
// ATRACE_NAME traces the beginning and end of the current function. To trace
// the correct start and end times this macro should be the first line of the
// function body.
// ATRACE_NAME traces the beginning and end of the current scope. To trace
// the correct start and end times this macro should be declared first in the
// scope body.
#define ATRACE_NAME(name) android::ScopedTrace ___tracer(ATRACE_TAG, name)
// ATRACE_CALL is an ATRACE_NAME that uses the current function name.
#define ATRACE_CALL() ATRACE_NAME(__FUNCTION__)
namespace android {

2
libs/utils/Trace.cpp
View File

@ -21,5 +21,5 @@ static void traceInit() __attribute__((constructor));
static void traceInit()
{
android::add_sysprop_change_callback(atrace_update_tags, 0);
::android::add_sysprop_change_callback(atrace_update_tags, 0);
}