ADHOC/replicant-frameworks_native
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove comparisons that can't be true

Browse Source 
keyBitmask and ledBitmask are arrays, "!their address" always evaluates to
false. clang complains about this.

Change-Id: I6aed45a203b0eeaad2093dbdebea03a2c2fc1a3d
Signed-off-by: Bernhard Rosenkränzer <Bernhard.Rosenkranzer@linaro.org>
This commit is contained in:
Bernhard Rosenkränzer 2014-11-17 21:09:14 +01:00
parent 55f71bc080
commit 6183eb72ec
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
services/inputflinger/EventHub.cpp
View File

@ -1443,7 +1443,7 @@ void EventHub::setLedForController(Device* device) {
} }
bool EventHub::hasKeycodeLocked(Device* device, int keycode) const { bool EventHub::hasKeycodeLocked(Device* device, int keycode) const {
if (!device->keyMap.haveKeyLayout() || !device->keyBitmask) { if (!device->keyMap.haveKeyLayout()) {
return false; return false;
} }
@ -1461,7 +1461,7 @@ bool EventHub::hasKeycodeLocked(Device* device, int keycode) const {
} }
status_t EventHub::mapLed(Device* device, int32_t led, int32_t* outScanCode) const { status_t EventHub::mapLed(Device* device, int32_t led, int32_t* outScanCode) const {
if (!device->keyMap.haveKeyLayout() || !device->ledBitmask) { if (!device->keyMap.haveKeyLayout()) {
return NAME_NOT_FOUND; return NAME_NOT_FOUND;
} }