ADHOC/replicant-frameworks_native
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

surfaceflinger: Fix range check for getFormat

Browse Source 
Fix potential buffer overflow error in getFormat with indices
greater than MAX_HWC_DISPLAYS.

Change-Id: I5e5b69d8d043e900f5e33ca9a62e94ae5f857b68
This commit is contained in:
Ajay Dudani 2015-05-03 11:44:55 -07:00 committed by Patrick Tjin
parent cbe13ef59b
commit 4e3e30c2d5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
services/surfaceflinger/DisplayHardware/HWComposer.cpp
View File

@ -461,7 +461,7 @@ sp<Fence> HWComposer::getDisplayFence(int disp) const {
} }
uint32_t HWComposer::getFormat(int disp) const { uint32_t HWComposer::getFormat(int disp) const {
if (uint32_t(disp)>31 || !mAllocatedDisplayIDs.hasBit(disp)) { if (static_cast<uint32_t>(disp) >= MAX_HWC_DISPLAYS || !mAllocatedDisplayIDs.hasBit(disp)) {
return HAL_PIXEL_FORMAT_RGBA_8888; return HAL_PIXEL_FORMAT_RGBA_8888;
} else { } else {
return mDisplayData[disp].format; return mDisplayData[disp].format;