ADHOC/replicant-frameworks_native
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Close Fence FDs in error cases of Surface and GraphicBufferMapper

Browse Source 
Surface::{cancel,queue}Buffer and GraphicBufferMapper::lockAsyncYCbCr take the
ownership of |fenceFd|s. Though they don't close it on error cases.

Change-Id: I49a7ce8837d5c510c4ac4ad4649f310d18610e80
(cherry picked from commit c7263fb432)
This commit is contained in:
Taiju Tsuiki 2015-04-30 22:15:33 +09:00 committed by Dan Stoza
parent 84f1d9c288
commit 4d0cd3f524
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libs/gui/Surface.cpp
View File

@ -267,6 +267,9 @@ int Surface::cancelBuffer(android_native_buffer_t* buffer,
Mutex::Autolock lock(mMutex); Mutex::Autolock lock(mMutex);
int i = getSlotFromBufferLocked(buffer); int i = getSlotFromBufferLocked(buffer);
if (i < 0) { if (i < 0) {
if (fenceFd >= 0) {
close(fenceFd);
}
return i; return i;
} }
sp<Fence> fence(fenceFd >= 0 ? new Fence(fenceFd) : Fence::NO_FENCE); sp<Fence> fence(fenceFd >= 0 ? new Fence(fenceFd) : Fence::NO_FENCE);
@ -308,6 +311,9 @@ int Surface::queueBuffer(android_native_buffer_t* buffer, int fenceFd) {
} }
int i = getSlotFromBufferLocked(buffer); int i = getSlotFromBufferLocked(buffer);
if (i < 0) { if (i < 0) {
if (fenceFd >= 0) {
close(fenceFd);
}
return i; return i;
} }

3
libs/ui/GraphicBufferMapper.cpp
View File

@ -164,6 +164,9 @@ status_t GraphicBufferMapper::lockAsyncYCbCr(buffer_handle_t handle,
bounds.left, bounds.top, bounds.width(), bounds.height(), bounds.left, bounds.top, bounds.width(), bounds.height(),
ycbcr); ycbcr);
} else { } else {
if (fenceFd >= 0) {
close(fenceFd);
}
return -EINVAL; // do not log failure return -EINVAL; // do not log failure
} }