From 457296ad6c8bf3533a90780a8c28ced84a2301e7 Mon Sep 17 00:00:00 2001 From: Stephen Hines Date: Thu, 4 Sep 2014 08:28:54 -0700 Subject: [PATCH] Fix undefined behavior (not returning a value from a function with return). Bug: 17379740 This function was missing a return statement, even though it declares a return type. This is undefined behavior, which clang miscompiled into just falling through to a later function in some cases. Adding the return statement fixes the undefined behavior (and probably fixes a bug too). Change-Id: I05c03b6473b831769dc4fa8b5ba43fb4249f7626 --- include/ui/mat4.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/ui/mat4.h b/include/ui/mat4.h index d9647cc1a..4fd1effd7 100644 --- a/include/ui/mat4.h +++ b/include/ui/mat4.h @@ -322,6 +322,7 @@ tmat44 tmat44::rotate(A radian, const tvec3& about) { r[ 1] = xy*nc + zs; r[ 5] = y*y*nc + c; r[ 9] = yz*nc - xs; r[ 2] = zx*nc - ys; r[ 6] = yz*nc + xs; r[10] = z*z*nc + c; } + return rotation; } // ----------------------------------------------------------------------------------------