ADHOC/replicant-frameworks_native
3
0
Fork 0
Code Issues 7 Pull Requests Releases Wiki Activity

Fix an issue where we could wait for a non-existing transaction

Browse Source 
This fixes the issue:
"Call not sent" dialog takes too long to dismiss after hitting OK"

Note: the system would recover after a 5 second timeout.

Bug: 5534520
Change-Id: Ifa37e594b50581f498479a5858672441b3d7dd87
This commit is contained in:
Mathias Agopian 2011-11-07 21:58:03 -08:00
parent a5f9676ecc
commit 386aa98c4f
1 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
services/surfaceflinger/SurfaceFlinger.cpp
View File

@ -1217,23 +1217,25 @@ void SurfaceFlinger::setTransactionState(const Vector<ComposerState>& state,
sp<Client> client( static_cast<Client *>(s.client.get()) ); sp<Client> client( static_cast<Client *>(s.client.get()) );
transactionFlags |= setClientStateLocked(client, s.state); transactionFlags |= setClientStateLocked(client, s.state);
} }
if (transactionFlags) {
setTransactionFlags(transactionFlags);
}
// if this is a synchronous transaction, wait for it to take effect before if (transactionFlags) {
// returning. // this triggers the transaction
if (flags & eSynchronous) { setTransactionFlags(transactionFlags);
mTransationPending = true;
} // if this is a synchronous transaction, wait for it to take effect
while (mTransationPending) { // before returning.
status_t err = mTransactionCV.waitRelative(mStateLock, s2ns(5)); if (flags & eSynchronous) {
if (CC_UNLIKELY(err != NO_ERROR)) { mTransationPending = true;
// just in case something goes wrong in SF, return to the }
// called after a few seconds. while (mTransationPending) {
LOGW_IF(err == TIMED_OUT, "closeGlobalTransaction timed out!"); status_t err = mTransactionCV.waitRelative(mStateLock, s2ns(5));
mTransationPending = false; if (CC_UNLIKELY(err != NO_ERROR)) {
break; // just in case something goes wrong in SF, return to the
// called after a few seconds.
LOGW_IF(err == TIMED_OUT, "closeGlobalTransaction timed out!");
mTransationPending = false;
break;
}
} }
} }
} }