ADHOC/replicant-frameworks_native
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge "fix an issue where updates could starve transactions"

Browse Source
This commit is contained in:
Mathias Agopian 2011-12-02 16:49:06 -08:00 committed by Android (Google) Code Review
commit 1d04d872b4
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
services/surfaceflinger/MessageQueue.cpp
View File

@ -44,8 +44,7 @@ void MessageBase::handleMessage(const Message&) {
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
MessageQueue::MessageQueue() MessageQueue::MessageQueue()
: mLooper(new Looper(true)), : mLooper(new Looper(true))
mInvalidatePending(0)
{ {
} }
@ -54,17 +53,13 @@ MessageQueue::~MessageQueue() {
void MessageQueue::waitMessage() { void MessageQueue::waitMessage() {
do { do {
// handle invalidate events first
if (android_atomic_and(0, &mInvalidatePending) != 0)
break;
IPCThreadState::self()->flushCommands(); IPCThreadState::self()->flushCommands();
int32_t ret = mLooper->pollOnce(-1); int32_t ret = mLooper->pollOnce(-1);
switch (ret) { switch (ret) {
case ALOOPER_POLL_WAKE: case ALOOPER_POLL_WAKE:
// we got woken-up there is work to do in the main loop // we got woken-up there is work to do in the main loop
continue; return;
case ALOOPER_POLL_CALLBACK: case ALOOPER_POLL_CALLBACK:
// callback was handled, loop again // callback was handled, loop again
@ -99,7 +94,6 @@ status_t MessageQueue::postMessage(
} }
status_t MessageQueue::invalidate() { status_t MessageQueue::invalidate() {
android_atomic_or(1, &mInvalidatePending);
mLooper->wake(); mLooper->wake();
return NO_ERROR; return NO_ERROR;
} }

1
services/surfaceflinger/MessageQueue.h
View File

@ -55,7 +55,6 @@ private:
class MessageQueue { class MessageQueue {
sp<Looper> mLooper; sp<Looper> mLooper;
volatile int32_t mInvalidatePending;
public: public:
MessageQueue(); MessageQueue();