From d640f89205e17d9f19b11c2954862f0945a40e7b Mon Sep 17 00:00:00 2001 From: Ben Cheng Date: Thu, 1 Dec 2011 17:11:32 -0800 Subject: [PATCH] Initialize bwr.read_buffer in IPCThreadState::talkWithDriver. I/valgrind( 1309): ==1310== Syscall param ioctl(BINDER_WRITE_READ).read_buffer points to uninitialised byte(s) I/valgrind( 1309): ==1310== at 0x480E670: __ioctl (__ioctl.S:10) I/valgrind( 1309): ==1310== Address 0xbda651b4 is on thread 1's stack Change-Id: I02893df7b5786b6b2dbd9659f5706d7171295ab2 --- libs/binder/IPCThreadState.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/libs/binder/IPCThreadState.cpp b/libs/binder/IPCThreadState.cpp index 5ccf87f2c..5d34787d6 100644 --- a/libs/binder/IPCThreadState.cpp +++ b/libs/binder/IPCThreadState.cpp @@ -773,6 +773,7 @@ status_t IPCThreadState::talkWithDriver(bool doReceive) bwr.read_buffer = (long unsigned int)mIn.data(); } else { bwr.read_size = 0; + bwr.read_buffer = 0; } IF_LOG_COMMANDS() {