ADHOC/replicant-frameworks_native
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix reading NULL Surfaces from Parcels

Browse Source 
Writing a NULL Surface was being read as a non-NULL Surface with NULL
mGraphicBufferProducer. Before the SurfaceTextureClient -> Surface
refactoring, you'd get a NULL Surface, and some code relies on that.

Bug: 8291161
Change-Id: I477bfe8882693e53a5f604a3d2c9e3cfe24473b4
This commit is contained in:
Jesse Hall 2013-03-02 16:25:32 -08:00
parent bbb57f3331
commit 006a601f22
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/gui/Surface.cpp
View File

@ -735,7 +735,7 @@ status_t Surface::writeToParcel(
sp<Surface> Surface::readFromParcel(const Parcel& data) { sp<Surface> Surface::readFromParcel(const Parcel& data) {
sp<IBinder> binder(data.readStrongBinder()); sp<IBinder> binder(data.readStrongBinder());
sp<IGraphicBufferProducer> bp(interface_cast<IGraphicBufferProducer>(binder)); sp<IGraphicBufferProducer> bp(interface_cast<IGraphicBufferProducer>(binder));
return new Surface(bp); return bp != NULL ? new Surface(bp): NULL;
} }
// ---------------------------------------------------------------------------- // ----------------------------------------------------------------------------